docs/tests for Minimal MeTTa functions #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated docstrings for several Minimal MeTTa functions to offer more insight on their behavior at least as documented in https://github.com/trueagi-io/hyperon-experimental/blob/main/docs/minimal-metta.md and as explained by Vitaly on the Mattermost.
minimal_metta_tests.metta
I intend to include basic, if you will minimal test cases that both provide behavioral coverage and augment the documentation. (I have not completed it for all of Minimal MeTTa yet, but the current tests are a good start.) They are based on my understanding of the Minimal MeTTa specification above and the Hyperon implementation's behavior. The Hyperon implementation currently passes all of these tests save for some of thecollapse-bind
tests, which appears to be an issue with equality checking forassertEqualToResult
rather than an issue with the test: the results returned match the test specification exactly. For example, in the Metta playground this fails but should succeed:Still, all in all the Hyperon implementation is currently doing quite well on test body I've created. Mettalog is not doing so well, only passing 10/36 of these new tests atm.